I have enabled Disco in the dailies now, because we will want to support it.

Some of the changes in appdata.xml need reverting. BTW these changes would be 
overwritten anyway, because we have a stub file so that we can automatically 
pull and insert translations from Transifex.

Diff comments:

> 
> === modified file 'debian/org.widelands.widelands.desktop'
> --- debian/org.widelands.widelands.desktop    2018-10-26 05:29:19 +0000
> +++ debian/org.widelands.widelands.desktop    2018-11-25 16:21:32 +0000
> @@ -76,4 +76,4 @@
>  Icon=widelands
>  TryExec=widelands
>  Exec=widelands
> -Categories=Game;StrategyGame;
> +Categories=Application;Game;StrategyGame;

Please remove "Application" aqain, the appstream spec has deprecated it.

> 
> === modified file 'debian/widelands.appdata.xml'
> --- debian/widelands.appdata.xml      2018-11-02 08:04:23 +0000
> +++ debian/widelands.appdata.xml      2018-11-25 16:21:32 +0000
> @@ -4,7 +4,6 @@
>    <id>org.widelands.widelands.desktop</id>
>    <metadata_license>CC0-1.0</metadata_license>
>    <project_license>GPL-2.0</project_license>
> -  <icon type="stock">widelands</icon>

Removing this will remove Widelands from Gnome appstores. Please add back in.

>    <name>Widelands</name>
>    <name xml:lang="ko">와이드랜드</name>
>    <summary>A real-time build-up strategy game</summary>
> @@ -373,14 +374,12 @@
>    <translation type="gettext">scenario_tutorial02_warfare.wmf</translation>
>    <translation type="gettext">mp_scenario_smugglers.wmf</translation>
>    <translation type="gettext">map_the_green_plateau.wmf</translation>
> -  <url type="homepage">https://wl.widelands.org/</url>
>    <url type="bugtracker">https://bugs.launchpad.net/widelands</url>
>    <url 
> type="donation">https://wl.widelands.org/wiki/The%20Widelands%20Project/</url>
>    <url type="help">https://wl.widelands.org/wiki/Game%20Manual/</url>
>    <url 
> type="translate">https://wl.widelands.org/wiki/TranslatingWidelands/</url>
>    <developer_name>The Widelands Development Team</developer_name>
> -  <update_contact>widelands-dev_at_lists.launchpad.net</update_contact>
> -  <content_rating type="oars-1.0">
> +  <x-content_rating type="oars-1.0">

Revert this change please. The x. was only added because the appstream 
validator hadn't caught up with the content rating feature when I first added 
it.

>      <content_attribute id="violence-cartoon">moderate</content_attribute>
>      <content_attribute id="violence-fantasy">none</content_attribute>
>      <content_attribute id="violence-realistic">none</content_attribute>


-- 
https://code.launchpad.net/~hjd/widelands/packaging-19-repack-6/+merge/359393
Your team Widelands Developers is requested to review the proposed merge of 
lp:~hjd/widelands/packaging-19-repack-6 into lp:widelands.

_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to     : [email protected]
Unsubscribe : https://launchpad.net/~widelands-dev
More help   : https://help.launchpad.net/ListHelp

Reply via email to