Code looks good so far. one nit in a diff. will download compile and test now.
Diff comments:
>
> === modified file 'data/tribes/wares/fire_tongs/helptexts.lua'
> --- data/tribes/wares/fire_tongs/helptexts.lua 2017-07-07 16:51:39
> +0000
> +++ data/tribes/wares/fire_tongs/helptexts.lua 2019-05-12 16:32:01
> +0000
> @@ -1,15 +1,15 @@
> function ware_helptext(tribe)
> local helptext = {
> -- TRANSLATORS: Helptext for a ware: Fire Tongs
> - default = pgettext("ware", "Fire tongs are the tools of the smelter,
> who works in the smelting works."),
> - -- TRANSLATORS: Helptext for a ware: Fire Tongs
> - atlanteans = pgettext("atlanteans_ware_fire_tongs", "They are produced
> by the toolsmith."),
> - -- TRANSLATORS: Helptext for a ware: Fire Tongs
> - frisians = pgettext("frisians_ware", "They are produced by the
> blacksmithy."),
> - -- TRANSLATORS: Helptext for a ware: Fire Tongs
> - barbarians = pgettext("barbarians_ware", "Produced by the metal
> workshop (but they cease to be produced by the building if it is enhanced to
> an ax workshop and war mill)."),
> - -- TRANSLATORS: Helptext for a ware: Fire Tongs
> - empire = pgettext("empire_ware_fire_tongs", "They are produced by the
> toolsmith.")
> + default = pgettext("ware", "Fire tongs are the tools for smelting
> ores."),
> + -- TRANSLATORS: Helptext for a ware: Fire Tongs
> + atlanteans = pgettext("atlanteans_ware_fire_tongs", "They are used in
> the smelting works and produced by the toolsmith."),
> + -- TRANSLATORS: Helptext for a ware: Fire Tongs
> + frisians = pgettext("frisians_ware", "They are used in the furnace and
> produced by the blacksmithy."),
frisians brickmaker use them as well
> + -- TRANSLATORS: Helptext for a ware: Fire Tongs
> + barbarians = pgettext("barbarians_ware", "They are used in the
> smelting works and produced by the metal workshop (but they cease to be
> produced by the building if it is enhanced to an ax workshop and war mill)."),
> + -- TRANSLATORS: Helptext for a ware: Fire Tongs
> + empire = pgettext("empire_ware_fire_tongs", "They are used in the
> smelting works and produced by the toolsmith.")
> }
> local result = ""
> if tribe then
--
https://code.launchpad.net/~widelands-dev/widelands/localization-post-build20/+merge/367305
Your team Widelands Developers is requested to review the proposed merge of
lp:~widelands-dev/widelands/localization-post-build20 into lp:widelands.
_______________________________________________
Mailing list: https://launchpad.net/~widelands-dev
Post to : widelands-dev@lists.launchpad.net
Unsubscribe : https://launchpad.net/~widelands-dev
More help : https://help.launchpad.net/ListHelp
