Review: Needs Fixing Hm, there is some inconsistency and an assertion:
1. Start widelands 2. Set a wrong password -> No hint about wrong password -> Login dialog closes 3. Trying to get into the lobby shows now a warning -> Loginbox appear 4. Set a wrong password again -> now the warning appears immediately 5. Close dialog by pressing 'Cancel' (did not test right click to close it) 6. Try to enter the lobby -> Assertion: widelands: /home/kaputtnik/Quellcode/widelands-repo/bug-1827786-metaserver-login-box-clean-start/src/ui_fsmenu/multiplayer.cc:134: void FullscreenMenuMultiPlayer::internet_login(): Assertion `!auth.empty()' failed. If feasible the warning about wrong password should appear also in step 2. I am fine with the wording though :-) -- https://code.launchpad.net/~widelands-dev/widelands/bug-1827786-metaserver-login-box-clean-start/+merge/367320 Your team Widelands Developers is subscribed to branch lp:~widelands-dev/widelands/bug-1825932-open-games-clean-start. _______________________________________________ Mailing list: https://launchpad.net/~widelands-dev Post to : [email protected] Unsubscribe : https://launchpad.net/~widelands-dev More help : https://help.launchpad.net/ListHelp
