https://bugzilla.wikimedia.org/show_bug.cgi?id=6908
Mike.lifeguard <[EMAIL PROTECTED]> changed:
What |Removed |Added
----------------------------------------------------------------------------
AssignedTo|[EMAIL PROTECTED] |wikibugs-
| |[EMAIL PROTECTED]
--- Comment #13 from Mike.lifeguard <[EMAIL PROTECTED]> 2008-11-22 19:20:27
UTC ---
(In reply to comment #12)
> First some specific comments (mostly nitpicks, except the second point):
>
> > 'Mytalk' => array( 'SpecialMytalk' ),
> >+ 'Myscript' => array(
> >'SpecialMyscript' ),
> >+ 'Mystyle' => array(
> >'SpecialMystyle' ),
> > 'Mycontributions' => array( 'SpecialMycontributions'
> > ),
>
> Spaces are being used for indentation here, not tabs, so that it aligns
> correctly regardless of tab width. That should be kept for the new entries.
>
> >+ return Title::makeTitle( NS_USER, $wgUser->getName() . '/' .
> >$wgUser->getSkin()->getSkinName() . '.css' );
> >...
> >+ return Title::makeTitle( NS_USER, $wgUser->getName() . '/' .
> >$wgUser->getSkin()->getSkinName() . '.js');
>
> Should this be makeTitleSafe, with error handling? What happens if the
> username plus skin name add up to more than 251 bytes or so? What if the skin
> name contains crazy characters?
>
> > class SkinChick extends SkinTemplate {
> >+
> >+ function getSkinName() {
>
> No need for the blank line here (or for any of the others).
>
> >+ return "chick";
>
> For strings where no interpolation is needed, single quotes are better style
> (and for all the others).
>
>
> More general issue: this doesn't work for custom skins. If they inherit from
> MonoBook, for instance, they would direct to monobook.css, which is wrong.
> The
> name should come from whatever is used by the bit of code that loads user CSS
> and JS. In fact, Skin::getSkinName() appears to be the function that's used,
> so whatever you're doing looks wrong. The problem is that the $skinname
> member
> variable is for some reason not initialized at this point. You should figure
> out why that is, initialize it, and then use getSkinName() without trying to
> manually override it and duplicate the info that's already set in
> $skin->skinname.
>
I totally do not understand what you are saying here. I think this is basically
beyond my abilities, so I'm removing myself from assigned.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
