https://bugzilla.wikimedia.org/show_bug.cgi?id=11009
Brion Vibber <[EMAIL PROTECTED]> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|FIXED |
--- Comment #2 from Brion Vibber <[EMAIL PROTECTED]> 2008-12-10 22:58:46 UTC
---
(That was r44254 ...)
I've reverted this in r44428
Doesn't seem like a proper fix here... At best, this'll be dumping random crap
to some random file unless the user has a local copy of the /dev/null device
file, which seems.... wrong. :)
For anything generating command lines, it probably won't make any difference
(assuming exec() is enabled at all!) since open_basedir won't be searching
through the command line (I think).
Assuming the core use case actually happens (open_basedir is set, but
proc_open() is available to run tidy), a more correct fix is probably to go
ahead and read in stderr and toss the results, or maybe better pass it through
to PHP's stderr FD instead of opening /dev/null ourselves. Tidy has a -q option
which should suppress random "hi i'm tidy version XYZ" if it's currently
present.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are watching all bug changes.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
