https://bugzilla.wikimedia.org/show_bug.cgi?id=15400


Aryeh Gregor <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
Attachment #5294 is|0                           |1
           obsolete|                            |




--- Comment #21 from Aryeh Gregor <[email protected]>  2008-12-24 
23:14:08 UTC ---
Created an attachment (id=5621)
 --> (https://bugzilla.wikimedia.org/attachment.cgi?id=5621)
Slightly fixed-up version of previous patch, rebased to recent trunk

(Term is over and I can get back to reviewing patches.  I didn't forget about
this.)

This is the same patch but with the following changes:

1) Works with current trunk, after r44879 (which I committed specifically so
this patch would be readable).

2) Removed border="none" on the image, which seems unnecessary.  We already do
this in CSS.

3) Adjusted one extra line to account for the extra div.  Without this extra
line, actually clicking the icon fails.

I haven't tested in browsers other than Firefox 3 yet.  display: inline-block
looks kind of weird . . .


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to