https://bugzilla.wikimedia.org/show_bug.cgi?id=15402
--- Comment #21 from SharkD <[email protected]> 2008-12-28 05:10:45 UTC --- (In reply to comment #18) > If I may interject -- please make a *minimal* patch for the sorting > optimization and include some basic benchmark data. (something like "Sorting > this table took 2000ms with the old code and 150ms with the new code, on a > machine with this configuration and with this browser") > Don't change style or code from other functions that's not vital to this > particular issue, so we can actually discuss the merits of the relevant code > instead of making general arguments about why very large patches with vague > descriptions are to be avoided. The latest patch *is* minimal, in that it only includes changes pertinent to the scope of this submission. I.e., it only includes changes that improve the performance of the script, or changes required for other changes to function properly. Secondly, I've *already* included a set of files which you yourself can be used to benchmark the performance increases. On my system, the performance improved from ~14000 milliseconds to between ~1400 and ~750 milliseconds depending on which column of the table you click. -Mike -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
