https://bugzilla.wikimedia.org/show_bug.cgi?id=15430
--- Comment #18 from Brion Vibber <[email protected]> 2009-01-05 18:59:40 UTC --- (In reply to comment #17) > In case this is an existing file, we never reach Article::doEdit, so it can > never fail at that. Mmm, true. That should simplify things a bit at least. :) > > Either we need to accept that failing the page is ok, or we need to be able > > to > > roll back the change to the actual file -- or else do it after, and be able > > to > > roll back all our DB and page updates if the file move fails. Icky. :( > > > What I think is that we should accept that LocalFile::recordUpload2 does not > always succeed. In case it doesn't it should be guaranteed that it did not > make > any changes and leave it to the caller to clean up the file. > > The current situation is that in case it fails, it may or may not leave a log > entry depending on what caused the failure. This seems to me less desirable > than a clear guarantee that no log entry has been left. We might want to consider what happens if various parts fail. Eg, if the edit succeeds, but the log entry fails, then we have to delete the page, the image record, and the file? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
