https://bugzilla.wikimedia.org/show_bug.cgi?id=16916
Summary: Unnecessary title disambiguation by cleanupImages.php
Product: MediaWiki
Version: 1.14-svn
Platform: All
URL: http://commons.wikimedia.org/wiki/File:Picswiss_BE-94-
01_Kirche_von_Würzbrunnen_(Röthenbach)_-_"Gotthelf-
Kirche%26quo_1.jpg
OS/Version: All
Status: NEW
Severity: minor
Priority: Normal
Component: Maintenance scripts
AssignedTo: wikibugs-l@lists.wikimedia.org
ReportedBy: nos...@vyznev.net
Since r43795, cleanupImages.php has moved the description pages of any misnamed
files along with the files themselves. While implementing this, a check was
added to ensure that the script won't try to move files to titles which already
have a description page, even if said page is not accompanied by an actual
file.
On the most recent cleanupImages run on Commons, this resulted in the misnamed,
descriptionless file "Picswiss BE-94-01 Kirche von Würzbrunnen (Röthenbach) -
"Gotthelf-Kirche&quo.jpg" being moved to the disambiguated title "Picswiss
BE-94-01 Kirche von Würzbrunnen (Röthenbach) - "Gotthelf-Kirche&quo 1.jpg"
(note the " 1"). The reason the script chose to disambiguate the title was
that there already was an existing page at "Picswiss BE-94-01 Kirche von
Würzbrunnen (Röthenbach) - "Gotthelf-Kirche&quo.jpg" -- in fact, it was the
description page belonging to the original file!
The old, pre-r43795 code would've simply reunited the file with its description
page, since it didn't pay any attention to the page table at all. Thus, this
is arguably a regression. It seems reasonable enough to assume that, if a
description page without a file already exists at the corrected title for a
file without a description page, they probably belong together. Certainly this
would seem extremely unlikely to occur by coincidence.
A single case would not merit adding an exception to the code, if it was
reasonably likely to be an isolated one. However, this was one case out of the
total of nine files moved in that run -- and all the other eight would've been
affected by the exact same problem if their description pages hadn't been
previously deleted. One actual case and eight narrowly averted ones seems
enough to justify a few extra lines of code, particularly since we have no idea
how frequent they might be elsewhere. "If it happened once, it will probably
some day happen again somewhere."
I already committed one fix to this problem as r45388, but it was reverted by
brion in r45478. I've written an alternative, possibly cleaner implementation,
which I'll attach to this bug as a patch. I'm filing this bug both for
discussion of this issue, and so that I'll have a bug number to refer to in
comments instead of having to repeat the whole incident report just to explain
what these few lines of code are there for.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
