https://bugzilla.wikimedia.org/show_bug.cgi?id=13209
Roan Kattouw <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #4684 is|0 |1 obsolete| | Attachment #4685 is|0 |1 obsolete| | --- Comment #20 from Roan Kattouw <[email protected]> 2009-01-12 23:40:57 UTC --- Created an attachment (id=5664) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=5664) Patch that adds diff functionality to prop=revisions The attached patch adds diff functionality to prop=revisions. It can: * diff all listed revs to a given revid (rvdiffto) * diff all listed revs to the previous rev of the same page (rvdifftoprev) * diff all listed revs to the top rev of the same page (rvdifftotop) * show diff size (bytes), diff lines and revids involved (rvdiffprop) Side effects of this patch: * all calls to getText() (get text if publicly available) changed to revText() (get text if available to the current user) * the revisions array in the output now uses revids rather than 0,1,2... as keys (technically a breaking change, although sane clients won't even notice) Performance considerations: * difftoprev and difftotop are only enabled when listing multiple revisions of the same page ** this means all revisions have the same top revision so it has to be fetched only once * difftoprev diffs to the previous/next revision IN THE LIST, which may not be the previous/next revision if rvuser/rvexcludeuser is used to filter stuff. Also, the last/first revision doesn't get a difftoprev ** this allows difftoprev to use only the revision texts already fetched * when diffs are generated, at most 50 revisions (500 for users with the apihighlimits right) are returned ** this means at most 150/1500 diffs are generated in one request *** 50/500 of these (diffto) have a low cache hit probability (diffto revision may not even belong to the same page) *** 50/500 of these (difftoprev) have a high cache hit probability *** 50/500 of these (difftotop) have a medium cache hit probability -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
