https://bugzilla.wikimedia.org/show_bug.cgi?id=17031





--- Comment #5 from Garrett <[email protected]>  2009-01-15 19:33:24 UTC ---
Here is an example of how an extension could benefit from accepting a larger
set of attributes:

The extension FBConnect (http://www.mediawiki.org/wiki/Extension:FBConnect)
enables wiki users to insert XFBML, an extension to XHTML designed by Facebook,
by reconstructing the tags and attributes as they are received from the
Sanitizer. With the current narrower set [A-Za-z0-9], attributes like
facebook-logo
(http://wiki.developers.facebook.com/index.php/Fb:profile-pic#Attributes) are
dropped from the attributes array in the parser hook.

To fix this issue, the following code

$attrib = '[A-Za-z0-9]';
$space = '[\x09\x0a\x0d\x20]';
define( 'MW_ATTRIBS_REGEX',
       "/(?:^|$space)($attrib+)
...

should be modified to be

$attrib_first = '[:A-Z_a-z]';
$attrib = '[:A-Z_a-z-.0-9]';
$space = '[\x09\x0a\x0d\x20]';
define( 'MW_ATTRIBS_REGEX',
        "/(?:^|$space)({$attrib_first}{$attrib}*)
...

I've attached this difference in patch form.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to