https://bugzilla.wikimedia.org/show_bug.cgi?id=15493


Nathanael <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]




--- Comment #6 from Nathanael <[email protected]>  2009-01-17 17:35:26 
UTC ---
The existing MSSQL support is not yet ready for prime time. I have attached a
diff against SVN revision 45842 to improve this. I have also attached already
patched versions of includes/db/DatabaseMssql.php and
maintenance/mssql/tables.sql for easy reference. Testing on Windows Server 2003
with IIS6 and SQL Server 2005 the only fault I am explicitly aware of is the
inability to create infinite duration blocks. Further testing will certainly
reveal others.

I am keen to get this into the tree as I believe it is at a reasonable point to
allow others to begin to test, and against which future work can proceed
incrementally.

Summary of changes:

* includes/db/DatabaseMssql.php : Correct various existing faults and reuse
existing functionality within Database.php wherever possible.

* maintenance/mssql/tables.sql : Data types adjusted and referential integrity
elements added (modelled off the Postgres version).

* includes/db/Database.php
  includes/Revision.php : Introduce EXPLICIT_ID option to support undelete
operations where an identity field is set explicitly. MSSQL requires specific
action in this case.

* includes/specials/SpecialRecentchanges.php
  includes/specials/SpecialRecentchangeslinked.php : MSSQL objects to ORDER BY
on the sub-queries (it remains present on the union results). The hardcoded
LIMIT option is removed from the union results but remains on the sub-queries.
This allows the LIMIT to be performed in an MSSQL compatible manner.

* includes/specials/SpecialListfiles.php : MSSQL requires GROUP BY lists to
include all non-aggregate fields. I believe Postgres will also require this.

* includes/specials/SpecialAncientpages.php : Add support for MSSQL datetime to
Unix time conversion.

* includes/specials/SpecialNewimages.php : Rewrite the query logic to use the
abstracted interfaces to allow the database abstraction mechanisms to work.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to