https://bugzilla.wikimedia.org/show_bug.cgi?id=17145
Aryeh Gregor <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] | |m --- Comment #2 from Aryeh Gregor <[email protected]> 2009-01-24 23:45:21 UTC --- + if ( isset( $this->mDoubleUnderscores['nounusedcat'] ) && $this->mTitle->getNamespace() == NS_CATEGORY ) { + $this->mOutput->setProperty( 'nounusedcat', 'y' ); + } I don't see any code to remove this property when it's been removed from the page -- does the Parser do that implicitly? I.e., if the magic word is removed, does it start showing up in UnusedCategories again? + AND pp_propname IS NULL + OR pp_propname != 'nounusedcat'"; I would prefer to see parentheses here: AND (... OR ...). Otherwise it's not clear to me that the logic is correct (I can't remember which way the association goes, and I'm sure I'm not the only one). 'hiddencat' => array( 1, '__HIDDENCAT__' ), + 'nounusedcat' => array( 1, '__NOUNUSEDCAT__' ), 'pagesincategory' => array( 1, 'PAGESINCATEGORY', 'PAGESINCAT' ), Indentation is wrong here. I'm not sure I like the name __NOUNUSEDCAT__. It's fairly confusing. Something like __SKIPUNUSED__ or __IGNOREUNUSED__ or something like that would be better -- maybe it really is unused, but we want to ignore that fact, is the point. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
