https://bugzilla.wikimedia.org/show_bug.cgi?id=1553





--- Comment #48 from Aryeh Gregor <[email protected]>  2009-02-01 
00:42:57 UTC ---
1) The proposed patch will fail in IE6, which does not support the [attr=val]
selector.  If use of advanced selectors were possible, incidentally, :lang()
would almost certainly be superior, or at least [lang^=de-] to avoid some of
the repetition.

2) I'm not sure it's a good idea to assume that Language::getCode() is valid to
put in an HTML lang= attribute.  The latter requires that only RFC1766 codes
may be used: does getCode() only output those, or does it also output invalid
codes in some cases?

3) You should probably ask Tim or Brion for commit access, if you haven't
already.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to