https://bugzilla.wikimedia.org/show_bug.cgi?id=17456
--- Comment #7 from Happy-melon <[email protected]> 2009-02-15 22:02:18 UTC --- "Rarely used"?? This code, or the old NavFrame code that it replaces, is included almost verbatim on seventeen of the top twenty Wikimedia wikis, including all ten largest wikipedias, and on the majority of the external wikis I checked, including Conservapedia, Uncyclopedia and Wikia. I suspect that your comment may have been something of a knee-jerk reaction. Equally, I don't see how this is possible to "do this all as a fully integrated"[sic] without JavaScript: it is already designed to fail gracefully in non-JS; successful print handling is as simple as adding @media print { table.collapsible td, table.collapsible th { /*For IE*/ display:inline !important; } table.collapsible td, table.collapsible th { /*For other browsers*/ display:table-cell !important; } } Along with the other CSS declaration - how exactly would you improve this further? By contrast, restricting the core stuff to helper functions achieves absolutely nothing: such features are the *easy* parts of this script to code, and wrapping them in another layer of abstraction would probably make the script *more* difficult to implement, not less. I agree that the collapsible toc could be consolidated into this feature, but given that the ToC is a table already, if this feature was implemented fully it would be utterly trivial to simply give the ToC the "collapsible" class and let the JS take over; we can lose the existing ToC code altogether if we incorporate the cookie 'memory' into CollapsibleTables, although I'm not sure how best that could be done. So really I don't see the strengths in your argument. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
