https://bugzilla.wikimedia.org/show_bug.cgi?id=17537

           Summary: Turn off zlib.output_compression for 304
           Product: MediaWiki
           Version: 1.15-svn
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: patch
          Severity: normal
          Priority: Normal
         Component: General/Unknown
        AssignedTo: wikibugs-l@lists.wikimedia.org
        ReportedBy: edwardzy...@thewritingpot.com


Created an attachment (id=5824)
 --> (https://bugzilla.wikimedia.org/attachment.cgi?id=5824)
Fixes bug

When PHP has zlib.output_compression enabled, it compresses all pages output,
regardless of their HTTP status code. Even empty pages get a ~13 byte empty
gzipped file tacked as their response. Unfortunately, for HTTP status code 304,
this is in direct violation of the specification; furthermore, if SSL and
Keep-Alive are enabled, Firefox gets sufficiently confused such as to post a
download page for the page immediately after the 304 with extra information
afterwards (it mixes up the packets).

I've attached a patch that fixes this bug by manually turning off
zlib.output_compression when a 304 is being sent. I am also coordinating with
PHP's maintainers to get this fixed upstream.

Relevant links:
https://bugzilla.mozilla.org/show_bug.cgi?id=363109 (bug for Firefox getting
confused by data after 304)
http://bugs.php.net/bug.php?id=42362 (bug for PHP not turning of
zlib.output_compression when there is empty output)


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to