https://bugzilla.wikimedia.org/show_bug.cgi?id=17591

           Summary: diff engine should use timestamps instead of revids to
                    count revisions between diffed versions
           Product: MediaWiki
           Version: 1.15-svn
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: Normal
         Component: History/Diffs
        AssignedTo: wikibugs-l@lists.wikimedia.org
        ReportedBy: pro...@aminche.com


Created an attachment (id=5836)
 --> (https://bugzilla.wikimedia.org/attachment.cgi?id=5836)
countRevisionsBetween using timestamps

For example
http://en.wikipedia.org/w/index.php?title=Apple&diff=269860524&oldid=234474
states:
(4580 intermediate revisions not shown) (4582)
instead of:
(4598 intermediate revisions not shown) (4600)

Because there is 18 revisions is Apple history which have rev_ids < 234474 and
timestamp > 2001-10-24T01:47:59Z
(see
http://en.wikipedia.org/w/api.php?action=query&prop=revisions&titles=Apple&rvprop=ids|user|timestamp&rvlimit=100&rvdir=newer&format=jsonfm)

Is this a known/real issues: is the intended behaviour to sort by revids when
counting revisions between diffed version ?

If not, feel free to review the attached patch, which switch
countRevisionsBetween behaviour to count revisions between timestamps instead
of revids.

Thanks in advance.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to