https://bugzilla.wikimedia.org/show_bug.cgi?id=17700

           Summary: Skin.php: $this->getSkinName() calls lowercase
                    skinname.css if $wgCapitalLinks is off
           Product: MediaWiki
           Version: 1.15-svn
          Platform: All
               URL: http://en.wiktionary.org/wiki/Special:BlankPage?useskin=
                    monobook
        OS/Version: All
            Status: NEW
          Severity: trivial
          Priority: Normal
         Component: Page rendering
        AssignedTo: [email protected]
        ReportedBy: [email protected]


<link rel="stylesheet"
href="/w/index.php?title=MediaWiki:Common.css&amp;usemsgcache=yes...
 <link rel="stylesheet"
href="/w/index.php?title=MediaWiki:monobook.css&amp;usemsgcache=yes...

With capitalized links off, getSkinName() passed through Title::makeTitleSafe
returns lowercased, eg "monobook.css". Message names always have to be
uppercase page names (with some exceptions).

However, this still works for this particular instance, as usemsgcache=yes
normalizes the case back to "Monobook.css", and returns the contents... but
this is a fragile situation. Several things could break it, and testing
skinname.css with $wgCapitalLinks is probably not done on every edit to
Skin.php ...?

Probably getSkinName() should be ucfirst'd there?


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to