https://bugzilla.wikimedia.org/show_bug.cgi?id=14418


Tim Starling <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]




--- Comment #13 from Tim Starling <[email protected]>  2009-03-11 
00:12:48 UTC ---
Put both field additions into the same patch. They can share an add_field call. 

Change the rd_ns_title index, it will need to have rd_interwiki at the start of
it.

-                       array('rd_namespace', 'rd_title'),
+                       array( 'rd_namespace', 'rd_title', 'rd_interwiki',
'rd_fragment' ),

Use "*", it's shorter

-                               'rd_title' => $retval->getDBKey()
+                               'rd_title' => $retval->getDBKey(),
+                               'rd_title' => $retval->getDBKey(),

You probably only need one of these.

        public function insertRedirect() {
-               $retval = Title::newFromRedirect( $this->getContent() );
+               $retval = Title::newFromRedirectRecurse( $this->getContent() );

This appears to be wrong and broken. There are two choices: have the redirect
table point to the final destination and use a separate tracking table to
update the table when the intermediate redirects change, or have the redirect
table point to the immediate destination and follow the chain on fetch. This
appears to be like the first option, except missing the complex update logic.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to