https://bugzilla.wikimedia.org/show_bug.cgi?id=22881
--- Comment #27 from Vitaliy Filippov <[email protected]> 2011-10-31 12:32:11 UTC --- Sorry, didn't see the comments - dnsrbl.net has gone mad and was blocking all email on my server :) Not fully, I've just implemented ZIP support by now, this required reworking writers/filters/readers, so now I have several questions to the devs: 1. What was the original idea besides Dump*Filters ? My opinion is that it's absolutely irrational to filter the pages AFTER loading them from the DB, plus DumpFilters weren't actually used in export, so I've removed them - is that OK ? 2. Also I don't truly understand the idea of having separate methods for write* (writeOpenPage, writeClosePage, etc) in DumpOutput. Was it supposed to allow easy switching of underlying stream format from XML to something other? I think it's useless as there is no other dump format by now :) so it's not designed for the real needs of other format. So it's also removed :) 3. Also, in the new version of patch, I always use temporary files to read/write dump archives, so the support for streaming gzip/bzip2/etc filters is also removed. But, my opinion is that it's also not a big problem - there's support for ZIP anyway. 4. Now, the import code doesn't restore recent changes for page edits/creations. I think it must restore them for consistency and I've implemented that - is it OK? 5. Also I don't fully understand the purpose of setting revision callbacks to methods of self in WikiImporter :) what's that purpose? 6. ImportStringSource - was this supposed to be really used somewhere? -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
