https://bugzilla.wikimedia.org/show_bug.cgi?id=32159

--- Comment #1 from seth <[email protected]> 2011-11-05 
11:36:16 UTC ---
The sbl extension searches for
  /https?:\/\/+[a-z0-9_\-.]*(\bexample\.com\b)

That means sbl entries always start with a domain part of a url. Actually
that's ok, because google-links like the above mentioned also include full
urls. The problem is that those urls are encoded (see
[[w:en:Percent-encoding]]) and the sbl extension does no decoding. So 
  ...?url=http%3A%2F%2Fwww.example.com
is not resolved as 
  ...?url=http://www.example.com

Solutions could be either
1. letting the regexp pattern start not with 
  /https?:\/\/+[a-z0-9_\-.]*(/
  but with 
  /https?(?i::|%3a)(?i:\/|%2f){2,}[a-z0-9_\-.]*(/
  or
2. decoding urls before doing the regexp matching.

(The second option is better for it is more general.)

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to