https://bugzilla.wikimedia.org/show_bug.cgi?id=18148
Summary: Faster short circuit and bugfix for check syntax errors
Product: MediaWiki extensions
Version: any
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: Normal
Component: AbuseFilter
AssignedTo: [email protected]
ReportedBy: [email protected]
CC: [email protected]
Created an attachment (id=5959)
--> (https://bugzilla.wikimedia.org/attachment.cgi?id=5959)
Patch and bugfix to extend short circuiting.
The attached patch extends the short circuit handling to more efficiently
bypass unnecessary sub-expressions. At the same time the patch fixes check
syntax errors related to short circuiting.
Based on benchmarking with function evaluation and variable lookup hacked off,
the extended short circuiting results in a ~20% improvement in parser speed for
typical cases.
Regarding the syntax check bug:
Currently short circuiting allows some expressions to pass syntax validation
even though they contain unknown keywords. An example of such an expression is
"added_lines & applesauce", which validates as okay even though "applesauce" is
meaningless.
This patch includes logic that fixes this short circuiting bug.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
