https://bugzilla.wikimedia.org/show_bug.cgi?id=25909
Niklas Laxström <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #5 from Niklas Laxström <[email protected]> 2011-11-08 12:55:34 UTC --- The code looks very good, except for minor detail of using 'or' instead of '||'. The user interface could perhaps be better, but that can be improved later if necessary. In testing I see: Warning: implode(): Invalid arguments passed in /www/sandwiki/includes/specials/SpecialRecentchanges.php on line 611 My wiki doesn't have any defined tags. It is probably also the reason why I don't see any filtering interface in the first place. Anyway, looks like changing return '' to return array() in ChangeTags::buildTagFilterWithDropdown fixes the warning. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
