https://bugzilla.wikimedia.org/show_bug.cgi?id=31511
[email protected] changed: What |Removed |Added ---------------------------------------------------------------------------- Version|1.18 |1.17 --- Comment #17 from [email protected] 2011-11-08 20:07:34 UTC --- Here is a simpler test case, after seeing this post to wikitech-l: http://lists.wikimedia.org/pipermail/wikitech-l/2011-November/056221.html Consider a gadget having the code ---- mwCustomEditButtons[ mwCustomEditButtons.length ] = { "imageFile": "//upload.wikimedia.org/wikipedia/commons/b/ba/Button_clipboard_category.gif", "speedTip": "Test", "tagOpen": "{{Foo|", "tagClose": "|Bar}}", "sampleText": 'Baz...' }; ---- If it is added to [[MediaWiki:Gadgets-definition]] without [ResourceLoader], there will be a new button in the (classic) toolbar when in edit mode. If we add [ResourceLoader] to the definition, the button disappears. I've confirmed this behavior on MW 1.17 and MW 1.18. On MW 1.18, the addition of [ResourceLoader] also causes the following message to appear in error console: ---- mw.loader::execute> Exception thrown by ext.gadget.Extra-Editbuttons: mwCustomEditButtons is not defined ---- Replacing mwCustomEditButtons by window.mwCustomEditButtons in the gadget's code doesn't fix it. And adding ---- window.mwCustomEditButtons = window.mwCustomEditButtons || []; ---- before the code only removes the error console message, but the button is still missing. The tests above were done on Google Chrome 15.0.874.106 and on Firefox 7.0.1. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
