https://bugzilla.wikimedia.org/show_bug.cgi?id=18153

           Summary: Patch radixRegex overmatching
           Product: MediaWiki extensions
           Version: any
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: Normal
         Component: AbuseFilter
        AssignedTo: [email protected]
        ReportedBy: [email protected]
                CC: [email protected]


Created an attachment (id=5960)
 --> (https://bugzilla.wikimedia.org/attachment.cgi?id=5960)
patch to prevent radixRegex catching empty strings

This was included in a previous patch but overlooked in the merging.

radixRegex in AbuseFilterParser::nextToken currently throws empty string
matches against non-numeric data.  Those matches are later discarded by another
part of the code, but because it is overmatching the number finding code
profiles as the 2nd or 3rd most expensive block in nextToken even though
numbers are relatively rare.

The attached patch prevents empty string matches.


-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to