https://bugzilla.wikimedia.org/show_bug.cgi?id=10023

Gabriel Wicke <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #9 from Gabriel Wicke <[email protected]> 2011-11-09 20:44:48 UTC 
---
Adding the following near the top of onView in RawAction.php also checks the
last-modified time with much less code and duplication:

if ( $this->getOutput()->checkLastModified( $this->page->getTouched() ) ) {
    return; // Client cache fresh and headers sent, nothing more to do.
}

Unfortunately this triggers the page data to be loaded in WikiPage, which
should be more expensive than what is currently done in RawAction. To prevent
the expensive load, an option would be to retrieve the revision outside
getRawText and use the returned timestamp to call checkLastModified. The full
text retrieval can then be avoided if checkLastModified returns true.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to