https://bugzilla.wikimedia.org/show_bug.cgi?id=21582

Santhosh Thottingal <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |i18n
                 CC|                            |[email protected]
                   |                            |om

--- Comment #19 from Santhosh Thottingal <[email protected]> 
2011-11-10 07:29:10 UTC ---
(In reply to comment #18)
> Thanks a lot!
> 
> I've fixed one little bug, maybe it will work now... Could you please test
> this: https://bugzilla.wikimedia.org/attachment.cgi?id=7789&action=diff

Thanks a lot for your efforts on this, apologies for the delay in getting this
applied to mediawiki.

I used the latest patch given, and to verify whether it actually works, I tried
some test cases. But I could not get it passed.

I tried this combination : "алейкум" => "aleyküm"
I get preg_replace(): Compilation failed: assertion expected after (?( at
offset 30
at regsConverter methods preg_replace call. This happens for Latin to Cyrillic
and reverse. 

I am not sure in what way you tested the transliteration. I used phpunit.
Created a class wiki/tests/phpunit/LanguageCrhTest with the following lines.

<?php
class LanguageCrhTest extends MediaWikiTestCase {
    private $lang;
    function setUp() {
        $this->lang = Language::factory( 'Crh' );
    }
    function tearDown() {
        unset( $this->lang );
    }
    function testTranslate() {
        $this->assertEquals($this->lang->mConverter->convertTo( 'aleyküm',
'crh-cyrl' ) ,'алейкум');
        $this->assertEquals($this->lang->mConverter->convertTo( 'алейкум',
'crh-latn' ) ,'aleyküm');
    }
}

and from phpunit folder,
php phpunit.php languages/LanguageCrhTest.php

Could you please follow this and expand the above test class with more test
cases and attach here? From the errors I am getting I assume that some of the
regular expressions constructed are not working.  But  the online tool
http://medeniye.org/transliterator/index.php gave me correct results.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to