https://bugzilla.wikimedia.org/show_bug.cgi?id=30390
Bawolff <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|need-review |patch, reviewed --- Comment #3 from Bawolff <[email protected]> 2011-11-10 17:52:05 UTC --- (In reply to comment #2) > Created attachment 9409 [details] > patch that removes url encoding in file name > > Hello, > I have made a patch to the javascript destination file name, to call the > javascript unescape function, that will remove the URL encoding where it > exists. Thank you for patch :). However, I think a more complicated function is needed. unescape doesn't handle unicode properly (unescape("%C4%A3") => Ä£ where it should be ģ) and the set of illegal characters in a file name don't entirely match up with the set of illegal chars in a url (Things like ][{}|#<> can't appear in titles). Just getting rid of the percent-encoding issue would probably be a major improvement (decodeURIComponent works much better than unescape for that), but there might already be a function available for title validation in our js stuff (I'm not sure, not all that familar with the js stuff) -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
