https://bugzilla.wikimedia.org/show_bug.cgi?id=32241

Lupo <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #4 from Lupo <[email protected]> 2011-11-10 23:50:00 UTC ---
Tried it with the "Bold" button. In IE8 debugger, each time the whole contents
scrolled and no sample text was inserted (i.e., when I had the window scrolled
to the top and nothing selected), the click() event bound on that button at
line 373 in jQuery.wikiEditor.toolbar.js simply didn't fire.

I didn't find out why, though.

I noticed this on-wiki change at the Commons:

https://commons.wikimedia.org/w/index.php?title=MediaWiki:Edittools.js&diff=60823115&oldid=60462490

Could that be related? What was the regression Die Buche fixed there?

I also do wonder if it's really necessary to bind handlers for both mousedown
and click on these buttons. Isn't a click handler sufficient, if it saves the
text scroll/text selection before calling ...toolbar.doAction()? Given that a
click is mousedown followed by mouseup, I could easily imagine that IE under
some circumstances might not trigger the click() if the mousedown() is
suppressed (e.preventDefault(), return false).

But then, I'm totally unfamiliar with this WikiEditor code, so I may be way
off, and there may be good reasons to use both events...

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to