https://bugzilla.wikimedia.org/show_bug.cgi?id=17905
Roan Kattouw <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #6584|0 |1 is obsolete| | --- Comment #5 from Roan Kattouw <[email protected]> 2011-11-14 11:56:10 UTC --- Created attachment 9442 --> https://bugzilla.wikimedia.org/attachment.cgi?id=9442 Rebased patch against trunk r102954 The patch didn't quite apply cleanly any more so I've rebased it against HEAD. I've attached it here but it can't be applied in its current state. It mostly looks good to me except for one critical thing: the logic involving $defaultPref and $defaultpref in CoreParserFunctions::formatDate() is very weird and looks like a mistake. Specifically, the second if ( $pref == 'default' ) condition looks like it will never be triggered, the existence of two different (!) variables $defaultPref and $defaultpref with different semantics is confusing, and there are no comments to clarify what's going on. Once that's fixed, the patch can be committed. I would fix it but I have no clue what you meant that particular piece of code to do and the most sensible behavior isn't obvious to me offhand. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
