https://bugzilla.wikimedia.org/show_bug.cgi?id=4947
--- Comment #30 from Platonides <[email protected]> 2011-11-17 16:23:10 UTC --- (In reply to comment #26) > Created attachment 9470 [details] > Updated patch for r103314 (VitaliyFilippov) > > Updated the patch. > Is it OK to use stream wrappers for SVGMetadataExtractor? > (I mean compress.zlib://) I had written an answer, which somehow isn't here :S Trying to summarise: * Noching against stream wrappers usage. * We should be able to work with normal svg even without zlib extension. * You are using fread() on a gzopen() handle. Which works, but is an undocumented feature. * Another option would be to use gzopen everywhere, and not check gzippiness. * The ( $size > $wgSVGMetadataCutoff ) check can be fooled by the compression. This could be extracted from the header in some cases, but the comment about a fake File instance being passed doesn't give me confidence. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
