https://bugzilla.wikimedia.org/show_bug.cgi?id=25563
Roan Kattouw <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #10 from Roan Kattouw <[email protected]> 2011-11-20 13:21:03 UTC --- I've reviewed this patch, and there's quite a few things wrong with it: * It uses Snoopy, which is unnecessary. We've got the Http class to make HTTP requests; if it doesn't support something you need, then add support rather than adding an external library * Lots of un-i18n-ed error messages and/or debugging stuff. Most of it's in English but one is actually in German. Also, using echo or die() for error messages is not acceptable (not sure offhand how it would be done though) * New $wg vars should be added to DefaultSettings.php (to protect against register_globals) and documented * Uses $wgTitle and uses direct member access (->mPrefixedText) instead of using getters (->getPrefixedText()) * Uses unserialize() without checking for errors * From reading the code I'm not convinced this patch will even work. It obtains login cookies, but then doesn't seem to use them For these reasons I'm marking the patch as obsolete. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
