https://bugzilla.wikimedia.org/show_bug.cgi?id=29569
Daniel Friesen <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mediawiki-bugs@nadir-seen-f | |ire.com --- Comment #4 from Daniel Friesen <[email protected]> 2011-11-21 02:22:18 UTC --- At the least we could use wfDebug or wfWarn. Taking a look at OutputPage.php right now we still use $module = $resourceLoader->getModule( $name ); and then right after start maing calls to $module. ResourceLoader::getModule explicitly says that the return value of getModule may be null, so this doesn't look like proper coding. That portion of OutputPage needs to properly guard against null module returns (just as we guard against null titles) and if it does any failing at all it should at the very least do so using a descriptive message about how a module does not exist, instead of throwing cryptic error messages as a result of trying to call something on null. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
