https://bugzilla.wikimedia.org/show_bug.cgi?id=3675
Daniel Kinzler <daniel.kinz...@wikimedia.de> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |daniel.kinz...@wikimedia.de
--- Comment #4 from Daniel Kinzler <daniel.kinz...@wikimedia.de> 2011-11-21
08:46:48 UTC ---
This patch is more than 6 years old :) Also, it was always kind of hackish. It
was supposed to address the following issue:
* when a file is uploaded and mediawiki fails to detect its mime type, it is
accepted withoput further checks.
* if we knew that the mime type of files with the given file extension *should*
be detected, we could reject that file (but afaik we currently don't).
I'm a bit out of the loop, and don't have time to test right now, but I believe
the problem still exist: garbage files that are detected as "unknown/unknown"
can be uploaded with any file extension.
I think the simples solution would be to reject files that are recognized as
"unknown/unknown" unless that extensions is whitelisted in a new config
variable.
On a related note: the interaction of $wgCheckFileExtensions vs.
$wgVerifyMimeType vs. $wgStrictFileExtensions is very unclear. The mime
detection / file verification code needs a rewrite. Sorry for the mess, that
stuff from 2005 is actually the first patch I contributed to mediawiki :)
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
Wikibugs-l@lists.wikimedia.org
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
