https://bugzilla.wikimedia.org/show_bug.cgi?id=31256
--- Comment #9 from Van de Bugger <[email protected]> 2011-11-22 21:54:09 UTC --- > You should unconditionally define it (with the default values)… No problem. > The is_array() check should be moved into checkUnicodeString() and die() > should be replaced with throwing a MWException. I tested both: throw new MWException( 'message...' ); and throw new ErrorPageError( 'page-title-msg-id', 'msg-id' ); and do not like both. The first one causes special page with stack backtrace, which is useless, because shows where the bug was found, but does not shows where the bug is. The second one allows localized messages, which is probably good. However, the biggest issue is that in both cases error is shown only when a user fills the registering form and press submit. Too late to my taste. It would be better if configuration errors re reported instead of *any* page. `die' in `AntiSpoof.php' provided such behaviour, so site admin will notice the error *very* soon. In the proposed approach the error will see only user trying to register. However, I do not insist on dying in `AntiSpoof.php'. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
