https://bugzilla.wikimedia.org/show_bug.cgi?id=6455
Robert Rohde <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |[email protected] --- Comment #68 from Robert Rohde <[email protected]> 2009-03-30 17:05:37 UTC --- (In reply to comment #66) > (In reply to comment #65) > > The attached file is complete rewrite of the StringFunctions extension. > > Shouldn't they just be added to ParserFunctions? I'm happy to write it up that way instead, though I don't know which is preferred. Given how long we and other sites have gone without working StringFunctions, it almost feels more natural to segregate them so that site operators have a choice. My main interest though is getting an implementation somewhere that is sufficiently reasonable that it can be used on the WMF sites. > > Where possible PHP's built-in multi-byte string functions are used provide > > fast > > results. If the mb_ functions are unavailable, their behavior is simulated > > in > > regex in order to provide a graceful (if slower) failure mode. > > We already have some of these compatibility functions in GlobalFunctions.php > (mb_strlen and mb_substr). You should use those, and add any additional ones > there. Okay. The one caveat is that my functions more or less assume they are being passed valid UTF-8 strings, and the encoding parameter for mb_strpos, etc. is not implemented. It appears that mb_strlen in GlobalFunctions is making the same assumption, so I'll assume that is okay for Mediawiki's purposes. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
