https://bugzilla.wikimedia.org/show_bug.cgi?id=32128

Krinkle <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[email protected]

--- Comment #19 from Krinkle <[email protected]> 2011-11-30 21:01:38 UTC ---
A rough review / suggestion:

--

Purging a user page (and any other place it will potentially be shown on)
because the user online status changes seems wrong. I haven't looked at the
extension deeply yet to know wether or not and if so how it does this, but if
it does, it shouldn't.

I suggest solving this with AJAX instead.

* users can set a preference to join/leave exposing their status
* users can set a preference to do or don't show other ppls statuses

By default we will probably want to make the first preference false and the
second one true.

Then the extension would have a scripts&style module, with position=>top,
loaded through addModules instead of addModuleStyles.
* a stylesheet + extra stylesheets for per-skin perfection
* one or more javascript files that will load this information from the API and
display in on the appropiate pages

The module would load dependent on the user preference (use the
BeforePageDisplay hook, then conditionally $out->addModules).

And, as noted, the information would have to be made available through an API
module.

While taking a quick look at the sql file, I noticed it uses column username
(VARCHAR 255) and timestamp (char 14). I suggest user IDs instead and
timestamps per MediaWiki convention (and columnames prefixed)
* os_user int unsigned NOT NULL
* os_timestamp binary(14) NOT NULL default '19700101000000'
(mysql types based on user.user_id and logging.log_timestamp [1])

--
Krinkle

[1]
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/maintenance/tables.sql?view=markup

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to