https://bugzilla.wikimedia.org/show_bug.cgi?id=32760

--- Comment #3 from Daniel Friesen <[email protected]> 
2011-12-02 02:27:20 UTC ---
(In reply to comment #2)
> (In reply to comment #1)
> > - Update the profiler docs so it stops using outdated docs that use
> > require_once lines and properly use the autoloader instead.
> 
> Profiler already uses AutoLoader and no require()s are necessary.
> StartProfiler.sample *was* updated when I refactored all of this.
Yeah, StartProfiler.sample is how I figured out that we autoload.

Our docs on the other hand will lead the many many people who don't read
StartProfiler.sample into adding bad require_once lines which will fatal in
1.18 either due to not having the file or having a 1.17 copy that causes
cryptic duplicate function fatals.
http://www.mediawiki.org/wiki/Profiling#Profiling


Now that I think about it, we should probably include a wfDeprecated(
'includes/ProfilerStub.php' ); into that no-op.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to