https://bugzilla.wikimedia.org/show_bug.cgi?id=32874
Web browser: ---
Bug #: 32874
Summary: Bitmap.php uses -define in ImageMagick configuration
line which requires ImageMagick 6.5.6-2 but doesn't do
a version check
Product: MediaWiki
Version: 1.19-svn
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Images and files
AssignedTo: [email protected]
ReportedBy: [email protected]
CC: [email protected], [email protected]
Classification: Unclassified
In Bitmap.php, around line 284, the code adds the -define option that requires
ImageMagick 6.5.6-2, but it doesn't check the version of ImageMagick first. It
looks like this:
// JPEG decoder hint to reduce memory, available since IM 6.5.6-2
$decoderHint = "-define jpeg:size={$params['physicalDimensions']}";
Later down in the file, it's done correctly like this:
if ( version_compare( $this->getMagickVersion(), "6.3.5" ) >= 0 ) {
$animation_post = '-fuzz 5% -layers optimizeTransparency +map';
}
Since -define is an optional flag here it should be wrapped in a version check
as well.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
