https://bugzilla.wikimedia.org/show_bug.cgi?id=30783

--- Comment #12 from Krinkle <[email protected]> 2011-12-22 22:37:14 UTC ---
(In reply to comment #8)
> A new Map instance for use by user scripts or gadgets would still
> make sense, even if mw.config is not used.
> 
> mw.config.twinkle = new Map();
> mw.config.twinkle.set({
>   showRollbackLinks: [ 'diff', 'others' ],
>   openTalkPageOnAutoRevert: true
> });
> 
> var revertSpecificConfigs = mw.config.twinkle.get({
>   showRollBacklinks: [],
>   openTalkPageOnAutoRevert: false
> });

This bug already closed but just want to quickly respond to the above.

Please don't extend the mw.config objects, certainly not for purposes that is
not related to MediaWiki's configuration object at all (since mw.config
instance of Map, which would render the mw.config non-standard with an extra
member in it).

In case you didn't know, the Map constructor is actually a public API that you
are encouraged to use if you want to.

e.g. 

mw.twinkle = {
  conf: new mw.Map(),
  init: function(){
  }
  ...
}

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to