https://bugzilla.wikimedia.org/show_bug.cgi?id=33537
Platonides <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|need-review |reviewed CC| |[email protected] --- Comment #4 from Platonides <[email protected]> 2012-01-09 17:59:07 UTC --- You are returning a Status object, but notifyOnPageChange() doesn't return anything (so the user-mail-enotif-list message is also unneeded). Also, I think you are passing too few parameters. You would want at least $watchers there, which could be modified to add/remove addresses (eg. you could have an extension which mailed a different team depending on the day of the week), something like the parameters of actuallyNotifyOnPageChange. Probably placed above "if ( $watchers ) {", but moving it outside its outer if. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
