https://bugzilla.wikimedia.org/show_bug.cgi?id=9767
--- Comment #61 from D J Bauch <dj.ba...@gmail.com> 2009-04-09 03:09:32 UTC --- (In reply to comment #60) > The patch (id 6005) seems to contains some strange modifications: > * AutoLoader.php: where's the file? > * Defines.php: this has nothing to do in core > * Revision.php: don't comment that out, it's needed for PostgreSQL > * SpecialShortpages.php, SpecialWantedcategories.php, SpecialWantedpages.php: > why commenting out the link existence batch? > * SpecialWantedtemplates.php: already fixed in r47618 > * SpecialListfiles.php: already fixed in r48350 > Yes, the modifications are strange in that they are not necessarily intended to replace the MySQL/PostgreSQL code in the trunk. They're only useful to someone trying to run on SQL Server. The file missing from autoloader.php is an attachment to the bug report (DatabaseADODB.php). It doesn't get picked up when I make the diff because it didn't exist before. The extra lines from my defines.php are for my extra namespaces and are optional. I'm assuming the commented out line you're referring to is the attempt to insert an ID in the text table. It won't work in my text table because the column is an auto-number column. I could make a view to eliminate this issue if necessary. The link existence batches don't work with the ADODB database adapter and not doing them didn't change the desired outcome. I may alter the ADODB database adapter to allow them to work at some time, but I don't own that code or have commit access on that project. Those last two already fixed issues were actually ones that I asked for but couldn't make myself (see comment #13 to this bug), since I don't have commit access. If I remember correctly, Tim Starling made the fixes back then. In addition to the patch file, you would need the tables.sql attachment above, the databaseadodb.php attachment above, and a patch to the ADODB library (which I could place here too, I suppose). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. You are the assignee for the bug. _______________________________________________ Wikibugs-l mailing list Wikibugs-l@lists.wikimedia.org https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
