https://bugzilla.wikimedia.org/show_bug.cgi?id=13692
Bawolff <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|need-review |reviewed --- Comment #5 from Bawolff <[email protected]> 2012-01-15 20:12:32 UTC --- Thank you for the patch. However, I don't think this is the right way of implementing this feature for several reasons: - Shouldn't use the borderline private methods of message cache - Questionable weather the template should be a specified in such an indirect way (Specify name, which resolves to a system message, which resolves back to a template, seems as if it should just directly take the template. I like mode=template, templatename=foo approach much better personally) - Some coding convention issues (but those issues are more reflective of the extension in general then of this patch). -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
