https://bugzilla.wikimedia.org/show_bug.cgi?id=33663
--- Comment #17 from Dan Nessett <[email protected]> 2012-01-19 21:00:49 UTC --- (In reply to comment #16) > (In reply to comment #11) > > I instrumented TestSuit.php (attached TestSuite.php.modified) to print out > > $wgLanguageCode on each test run. When I run make safe, its value changes to > > "zh" on the 429th ParserTest (attached Full Safe Tests Run.txt) and stays > > that > > way for the rest of the run. I couldn't figure out why until I looked at the > > incomplete tests. The 20th incomplete test changes the language to "zh"... > > Tests changing the language should extend MediaWikiLangTestCase (which saves & > restores it), not MediaWikiTestCase. > The test that changes the language is the ParserTest, which runs a whole bunch of sub-tests of the parser functionality. Most of these do not change the language. I still don't quite understand how the parser tests are run within the PHPUnit framework, so I don't know if one PHPUnit test runs all parser tests or each test runs under a separate instance of MediaWikiTestCase. In the latter case, it makes sense to run those tests that change the language out of MediaWikiLangTestCase. In the former case, it may or may not make sense > > > and then fails after 1 second. So, my guess is there is no proper unwinding > > of > > incomplete tests and they leave globals in a non-initialized state. > > What I wonder is, what makes your tests to abort after 1 second? > I have never seen that myself. I was hoping someone would indicate what might cause such timeouts and suggest a way to fix the problem. I have no idea why they are aborting after 1 second. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
