https://bugzilla.wikimedia.org/show_bug.cgi?id=33711
--- Comment #10 from [email protected] <[email protected]> 2012-01-19 21:12:17 UTC --- (In reply to comment #8) > Your logic fails... $ and $content are unrelated. I suggest you read the changes Krinkle made. I know that they are not the same. But you should also read what Krinkle wrote here: > Since mw.util.$content wasn't used there it's fine now. It is used within a $(document).ready hook but that's fine. Krinkle thinks that when adding a dependency to mw.util AND wrapping the code accessing mw.util.$content inside a $(document).ready(function(){...}) or its short form $(function(){...}), mw.util.$content must be defined, which is not the case here why I reopened the bug. http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/resources/mediawiki/mediawiki.util.js?view=markup#l58 If you look at the source-code of the mw.util -module you will see that $content is predefined with null and there is a "init"-method that sets $content to what it should be. The problem? is that init can only be invoked by $(document).ready() because RL-modules may be loaded before the DOM is ready. So the question to solve is, why mw.util.$content is null. > I've reverted Rillke's changed to MediaWiki:Common.js on commons.wikimedia.beta.wmflabs back to the original, and wrapped it in mw.loader.using. http://commons.wikimedia.beta.wmflabs.org/w/index.php?title=MediaWiki%3ACommon.js&diff=22461&oldid=22442 sans commentaire -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
