https://bugzilla.wikimedia.org/show_bug.cgi?id=33952
--- Comment #6 from Krinkle <[email protected]> 2012-01-30 23:29:09 UTC --- (In reply to comment #5) > Krinkle, is this really something that needs to block a 1.19 release? Well, I'd say it's your call. Any code written in 2011 or later should probably be providing tools for users with Vector/WikiEditor, not Monobook/Classic toolbar. WikiEditor has very good javascript hooks whereas the the classic toolbar's are crap (and always have been kind of hacky). Scripts manipulating the classic toolbar will fail if they load themselves as a resource module because the legacy code for the toolbar bypasses most of resource loader. -> Either we force users to keep their classic-toolbar enhancement scripts un-resourceloaderified, or the classic toolbar needs to be resource loaderified. It's not a regression in 1.19, but race conditions are more likely in 1.19 due to speed. And unfortunately, contrary to the module story, there is no "right" way to edit the classic toolbar without having a race condition, simply because the classic toolbar isn't in the normal flow of execution. It exposes a global array where scripts can add things to, and at some point around document-ready event it builds the toolbar with the buttons in the array at that moment, and then the array is further ignored. -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
