https://bugzilla.wikimedia.org/show_bug.cgi?id=34114
Web browser: ---
Bug #: 34114
Summary: CSSMin function remap not respecting $embed
Product: MediaWiki
Version: 1.18.1
Platform: All
OS/Version: All
Status: NEW
Severity: normal
Priority: Unprioritized
Component: Resource Loader
AssignedTo: [email protected]
ReportedBy: [email protected]
CC: [email protected], [email protected],
[email protected]
Classification: Unclassified
The parameter list of CSSMin::Remap allows for the option $embed with which you
can set if the embedding of images has to be done. Currently the $embed
variable is overwritten at position 150 ($embed = $match['embed'][0];).
Suggestion:
Change the function params to this:
public static function remap( $source, $local, $remote, $embed_data = true )
-----
and at line 159-160, change:
-----
// Embedding requires a bit of extra processing, so let's skip that if we can
if ( $embed ) {
-----
to:
-----
// Embedding requires a bit of extra processing, so let's skip that if we can
if ( $embed_data && $embed ) {
This way, even if CSSMin finds /* @embed */ comments it can be overwritten for
performance/size reasons.
--
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.
_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
