https://bugzilla.wikimedia.org/show_bug.cgi?id=18492
Roan Kattouw <[email protected]> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |need-review, patch --- Comment #5 from Roan Kattouw <[email protected]> 2009-04-18 18:43:51 UTC --- (In reply to comment #4) > Created an attachment (id=6035) --> (https://bugzilla.wikimedia.org/attachment.cgi?id=6035) [details] > Previous attachment in correct form > Some trivial problems with this patch: * you have a typo in Article.php: limitResults() should be limitResult() * the patch removes WantedQueryPage from AutoLoader.php * you're copying code from Database::__construct() to DatabaseOracleSS::__construct(), instead just call parent::__construct(). This trick works for other functions as well (haven't checked for code duplication everywhere) * use Doxygen comments (/** ... */) for the docs above a function declaration. Hash comments (# ...) won't work there This really needs to be reviewed by someone with more DB expertise than I have, though -- Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the assignee for the bug. You are on the CC list for the bug. _______________________________________________ Wikibugs-l mailing list [email protected] https://lists.wikimedia.org/mailman/listinfo/wikibugs-l
