https://bugzilla.wikimedia.org/show_bug.cgi?id=17616

Dan Wolff <[email protected]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Version|1.15.x                      |1.19-svn

--- Comment #10 from Dan Wolff <[email protected]> 2012-02-13 23:27:42 UTC ---
Relevant code:
http://svn.wikimedia.org/viewvc/mediawiki/trunk/phase3/resources/jquery/jquery.makeCollapsible.js?revision=94389&view=markup#l180

Krinkle, is it necessary to prevent an <a> element from initiating the toggle?

We want to be able to click the <a> to toggle (or press enter while it is
focused), so that can't be prevented.

I can think of a few solutions:
* Don't prevent <a> elements (is this prevention needed anywhere?)
* Add a parameter allowLinkAsTarget
* Add a class to $that element to indicate that links (i.e.
.mw-collapsible-toggle.mw-collapsible-allow-link)
* Add a new function which doesn't prevent <a> elements


Also, as a note: We'll need to change the HTML to only have *one* <a> for both
images, since we don't want to focus the <a> when the page loads (the toggling
function is performed once).

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to