https://bugzilla.wikimedia.org/show_bug.cgi?id=34453

       Web browser: ---
             Bug #: 34453
           Summary: Extension:NewPageCSS is merely a bugfix which should
                    be merged into existing in-SVN extension PageCSS
           Product: MediaWiki extensions
           Version: any
          Platform: All
        OS/Version: All
            Status: NEW
          Keywords: need-review
          Severity: enhancement
          Priority: Unprioritized
         Component: PageCSS
        AssignedTo: [email protected]
        ReportedBy: [email protected]
    Classification: Unclassified


Created attachment 10026
  --> https://bugzilla.wikimedia.org/attachment.cgi?id=10026
new PageCSS.php from [[mw:Extension:NewPageCSS/Source]]

[[mw:Extension:NewPageCSS]] (which has source code on-wiki) is not a fully-new
extension but a minor fix to [[mw:Extension:PageCSS]], an extension already in
SVN.

It's now tagged {{Extension code in wiki}} as if it were a separate extension,
but it differs from the PageCSS currently in SVN only in bug fixes needed to
keep the extension working on MediaWiki 1.16-1.17 (replace raw Unicode
characters in the author's name with HTML æ - style codes) and MediaWiki
1.18-1.20 (return the empty string, "", where the original would have had the
tag hook stuff the CSS into the page headers and return nothing at all, leaving
annoying UNIQ-123456789-css-0000000-QINU tags in the displayed page. Parser
tags *must* return a value, so this is just a bug fix.

I propose that NewPageCSS be merged back to PageCSS and the current (repaired)
code placed back into SVN at the original name. There is no need to list this
on-wiki as two extensions if one is a trivial debugged copy of the other and no
need to propose a new extension be created in SVN when fixing the existing file
suffices.

I'm not sure whether I should be proposing this here or on-wiki but, since this
is SVN content, a {{merge}} template on-wiki didn't seem to be quite suited as
both the wiki and SVN would be updated by any attempt to merge the two
versions.

-- 
Configure bugmail: https://bugzilla.wikimedia.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.

_______________________________________________
Wikibugs-l mailing list
[email protected]
https://lists.wikimedia.org/mailman/listinfo/wikibugs-l

Reply via email to